Fix incorrect inheritdoc blocks #5718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,6 +24,9 @@ | |||
| */ | |||
| class TraceableControllerResolver extends ControllerResolver | |||
| { | |||
| /** | |||
| * @var Stopwatch | |||
| */ | |||
There was a problem hiding this comment.
Symfony does not put the docblock for private properties
There was a problem hiding this comment.
@stof removed and rebased.
FYI, I couldn't see anywhere that it says not to add docblocks to private member variables and there's plenty of code in the library that does so. It allows autocomplete for IDEs, so I don't see why it should be omitted. Anyway, each to their own I've fixed it.
There was a problem hiding this comment.
@stof there is no such rule and the form component uses docblocks for private properties. Why should it hurt?
Also add a docblock to stopwatch member variable. Remove docblock from private member
fabpot
added a commit
that referenced
this pull request
Oct 11, 2012
This PR was merged into the master branch. Commits ------- 74e2c5e Fix incorrect inheritdoc blocks Discussion ---------- Fix incorrect inheritdoc blocks Also add a docblock to stopwatch member variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a docblock to stopwatch member variable.