[Cache] fix integration tests #57201
fix integration tests
- Loading branch information
commit a0f9a322e3970dc425e76fef8c772f9d72c94beb
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexandre-daubois @nicolas-grekas I am not really sure why this is required. Does the
CouchbaseCollectionAdapterwork differently than theCouchbaseBucketAdapter?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was the starting point of #57192 😄
This was changed to ensure that the Couchbase adapter is decoding special chars from password and you're able to put an encoded
@in it.@is used to separate user:pass from the actual hostname, making it impossible to use the raw value as-is. Special chars decoding is currently done on a case-by-case basis in each DSN adapter parser.Secondly, why those two classes? If I remember correctly, one of the adapter is deprecated and used for an old version of Couchbase, whereas the other one is the one to use in new application. Those versions are incompatible and only one version is tested in the integration test suite. Otherwise it would require to run two Couchbase instance but that's super complicated (partly because they need different min versions of PHP, among other things).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the decoding is not necessary in our integration tests as username and password are passed separately and are not part of the DSN. But that was also the case when we ran tests with the
CouchbaseBucketAdapter. That's why I wondered if there was another difference which explains why we need this change to make tests pass.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that I can remember 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some hard times debugging this adapter, it is (very) complicated to test on a local machine. The fact it is unstable on the CI makes me wonder even more if this shouldn't be deprecated. The version supported by our adapter is old and no contributions seems planned to bring support for newer versions. I think the question of the deprecation arises.