[HttpKernel] MapQueryString/MapRequestPayload do not skip validation when empty request is sent #57206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3f3a6c to
8972cb1
Compare
yceruto
requested changes
Jun 19, 2024
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/RequestPayloadValueResolver.php
Outdated
Show resolved
Hide resolved
...y/Component/HttpKernel/Tests/Controller/ArgumentResolver/RequestPayloadValueResolverTest.php
Show resolved
Hide resolved
...y/Component/HttpKernel/Tests/Controller/ArgumentResolver/RequestPayloadValueResolverTest.php
Show resolved
Hide resolved
yceruto
requested changes
Jun 19, 2024
src/Symfony/Bundle/FrameworkBundle/Tests/Functional/ApiAttributesTest.php
Outdated
Show resolved
Hide resolved
129c4d9 to
861384e
Compare
yceruto
requested changes
Jun 20, 2024
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/RequestPayloadValueResolver.php
Outdated
Show resolved
Hide resolved
…ion when empty request is sent resolves symfony#54617
|
We hadn't discussed the target branch before, and I assumed you were working on 7.2 (sorry about that). We usually only improve behaviors/exceptions in the newest branch (e.i. 7.2), and I'm afraid this won't be an exception |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MapQueryString/MapRequestPayload skips validation when empty request is sent