[Messenger] Allow to skip message in FailedMessagesRetryCommand
#57270
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
FailedMessagesRetryCommand
There was a problem hiding this comment.
Does this implementation mean that skipping will update the failure date? If yes, is there any way around?
Is there no way to just NACK the message and go to the next one?
Note that the answer might be just "no" by design, I don't remember this aspect :)
Anyone else can tell?
Update CHANGELOG message and help message
d9ce65f to
7ec6914
Compare
Sure, it's done ! 👍 |
|
Thank you @Kazadri. |
| $choice = $io->choice('Please select an action', ['retry', 'delete', 'skip'], 'retry'); | ||
| $shouldHandle = $shouldForce || 'retry' === $choice; |
There was a problem hiding this comment.
With this change the user is always asked to select an option even if --force was used.
I'm going to prepare a fix
EDIT see #60293
When retrying message with the command messenger:failed:retry, we have two options:
But sometimes we have no clue if we can retry it or not but I know that we don't want to delete it yet. In that case we need to stop the command and go id by id. The interactive command is lost. The command should provide a way to skip a message to continue with the rest of the failed message.