Skip to content

[DependencyInjection] Fix phpdoc for $calls in class Autoconfigure #57289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2024
Merged

[DependencyInjection] Fix phpdoc for $calls in class Autoconfigure #57289

merged 1 commit into from
Jun 25, 2024

Conversation

ThomasTr
Copy link
Contributor

@ThomasTr ThomasTr commented Jun 2, 2024

Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues None
License MIT

PHPDoc for $call in class Autoconfigure should be array<array-key, array<array-key, mixed>>|null
As usage is:

calls: [
        ['method' => 'setEntityManager', 'arguments' => ['@doctrine.orm.entity_manager']]
    ]

@carsonbot carsonbot added this to the 7.1 milestone Jun 2, 2024
@nikolasok nikolasok mentioned this pull request Jun 4, 2024
Closed
@ThomasTr ThomasTr force-pushed the fix-phpdoc-autoconfigure branch from 4922515 to ebb27d2 Compare June 25, 2024 15:36
@fabpot
Copy link
Member

fabpot commented Jun 25, 2024

Thank you @ThomasTr.

@fabpot fabpot merged commit 48c1c3d into symfony:7.1 Jun 25, 2024
5 of 10 checks passed
@fabpot fabpot mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug DependencyInjection Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ThomasTr @fabpot @nicolas-grekas @carsonbot