[Cache] Add a note about the change in the default cache namespace generation to the upgrade guide #57302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wouldn't describe this as a BC break. We consider that a minor update isn't required to not invalidate caches (but we'd prefer when possible). Here, it's too late for reverting IMHO. |
… to the upgrade guide
c652caf to
f536f3c
Compare
CachePoolPass|
PR updated |
nicolas-grekas
approved these changes
Jun 11, 2024
fabpot
approved these changes
Jun 11, 2024
|
Thank you @mbabker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After deploying the Symfony 7.1 upgrade for a client, we immediately noticed a high rate of cache misses for one of our heavily used controller actions. Digging through the changes for the relevant upstream packages, it looks like this was introduced by way of #52948 and changing the algorithm used for the default cache namespaces when a
namespaceattribute isn't configured on thecache.poolservice tag.To my knowledge, there is no way to configure a namespace for cache pools using the
framework.cacheconfiguration, so through the framework configuration, there is no way to avoid hitting this issue without either manually building cache services or getting creative with a compiler pass that runs before the coreCachePoolPass, so IMO it's best to call out the change in the upgrade guide.