-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Uid] Make AbstractUid
implement Ds\Hashable
if available
#57313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
b417d14
to
055e71a
Compare
OskarStark
reviewed
Jun 5, 2024
xabbuh
reviewed
Jun 5, 2024
derrabus
reviewed
Jun 5, 2024
AbstractUid
implement Ds\Hashable
if available
055e71a
to
878da02
Compare
xabbuh
reviewed
Jun 5, 2024
xabbuh
reviewed
Jun 5, 2024
878da02
to
9b9dbb9
Compare
nicolas-grekas
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use psalm as a tool that could give useful hints, but that could also generate false-positives 🤷
xabbuh
reviewed
Jun 5, 2024
9b9dbb9
to
1a0d9b0
Compare
fabpot
approved these changes
Jun 7, 2024
Thank you @jahudka. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes UUIDs usable with the PHP DS extension's
Map
andSet
classes. It's a new feature and shouldn't cause any BC breaks.The
Map
andSet
classes in the DS extension have extended support for objects implementing theDs\Hashable
interface (as keys inMap
and values inSet
). By default, values are made unique by testing for strict equality, which will consider twoUuid
instances to be distinct even though they represent the same UUID; with this PR merged,Uuid
instances would behave as expected with these classes.The current implementation of
AbstractUid
already includes theequals()
method defined in the interface; the PR adds the missinghash()
method and a shim for the interface in case the extension isn't loaded. I've also added a test for the newhash()
method, checking both the behaviour of the method itself and the correctness of that behaviour when used with theDs\Set
class (that part of the test only runs if theds
extension is loaded).I've read through the contributing docs, but it's still my first time contributing to Symfony, I'm sure I've made mistakes - please don't be too harsh on me! 🙏 ❤️