[Serializer] avoid calling undefined built-in is_*() functions #57320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jun 5, 2024
| Q | A |
|---|---|
| Branch? | 7.1 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix #57314 |
| License | MIT |
Comment on lines
569
to
583
| $dataMatchesExpectedType = match ($builtinType) { | ||
| LegacyType::BUILTIN_TYPE_ARRAY => \is_array($data), | ||
| LegacyType::BUILTIN_TYPE_BOOL => \is_bool($data), | ||
| LegacyType::BUILTIN_TYPE_CALLABLE => \is_callable($data), | ||
| LegacyType::BUILTIN_TYPE_FALSE => false === $data, | ||
| LegacyType::BUILTIN_TYPE_FLOAT => \is_float($data), | ||
| LegacyType::BUILTIN_TYPE_INT => \is_int($data), | ||
| LegacyType::BUILTIN_TYPE_ITERABLE => is_iterable($data), | ||
| LegacyType::BUILTIN_TYPE_NULL => null === $data, | ||
| LegacyType::BUILTIN_TYPE_OBJECT => \is_object($data), | ||
| LegacyType::BUILTIN_TYPE_RESOURCE => $data, | ||
| LegacyType::BUILTIN_TYPE_STRING => \is_string($data), | ||
| LegacyType::BUILTIN_TYPE_TRUE => true === $data, | ||
| default => false, | ||
| }; |
There was a problem hiding this comment.
Would worth a private method maybe? As you're using the same logic twice?
There was a problem hiding this comment.
In fact, the legacy type doesn't support mixed here. So I have reverted these changes.
derrabus
reviewed
Jun 5, 2024
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
derrabus
reviewed
Jun 5, 2024
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
derrabus
approved these changes
Jun 6, 2024
stof
approved these changes
Jun 6, 2024
|
Hello! When are we planning to release this? It's a breaking change for us. |
|
Patch releases are published once a month. |
xabbuh
added a commit
that referenced
this pull request
Jun 16, 2024
…ypes (xabbuh) This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] properly handle invalid data for false/true types | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #57320 (comment) | License | MIT Commits ------- d35d4a3 properly handle invalid data for false/true types
symfony-splitter
pushed a commit
to symfony/serializer
that referenced
this pull request
Jun 16, 2024
…ypes (xabbuh) This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] properly handle invalid data for false/true types | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix symfony/symfony#57320 (comment) | License | MIT Commits ------- d35d4a337b properly handle invalid data for false/true types
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.