[PropertyInfo] Skip extractors that do not implement getType
#57363
Conversation
llupa
commented
Jun 10, 2024
| Q | A |
|---|---|
| Branch? | 7.1 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | yes |
| Issues | Fix #57360 |
| License | MIT |
|
I did not put any update on |
| if (!method_exists($extractor, $method)) { | ||
| trigger_deprecation('symfony/property-info', '7.1', 'Not implementing the "%s()" method in class "%s" is deprecated."', $method, $extractor::class); | ||
|
|
||
| continue; |
There was a problem hiding this comment.
This does not look like the right solution to me as it means that a formerly used extractor will now no longer be used leading to a (potentially) different result.
There was a problem hiding this comment.
I completely agree. I tried to put a message somewhere several times, but I was undecided and thought to have the PR rolling to have more feedback / ideas.
There was a problem hiding this comment.
Also, I thought about strictly checking for getType and have it default to getTypes and it would work for return values that have only 1 Type in the return array of getTypes. I think this change was done before: #54694. Most of the code in property-info thinks BIGINT is string and not this dual type scenario.
There was a problem hiding this comment.
see #57459 for another attempt
|
Closing in favor of #57459 |