[Validator] fix IBAN validator fails if IBAN contains non-breaking space #57380
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
4497742 to
8a6ec10
Compare
| @@ -163,9 +163,6 @@ class IbanValidator extends ConstraintValidator | |||
| 'YT' => 'FR\d{2}\d{5}\d{5}[\dA-Z]{11}\d{2}', // France | |||
| ]; | |||
|
|
|||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
There was a problem hiding this comment.
I suppose that this comes from fabbot. This should be reverted as not related to this PR.
| // Remove spaces and non-breaking spaces and convert to uppercase | ||
| $canonicalized = str_replace([' ', '\XC2\XA0'], '', strtoupper($value)); |
There was a problem hiding this comment.
| // Remove spaces and non-breaking spaces and convert to uppercase | |
| $canonicalized = str_replace([' ', '\XC2\XA0'], '', strtoupper($value)); | |
| // Remove spaces (regular, non-breaking, and narrow non-breaking) and convert to uppercase | |
| $canonicalized = str_replace([' ', "\xc2\xa0", "\xe2\x80\xaf"], '', strtoupper($value)); |
There was a problem hiding this comment.
Thanks for the suggestion.
1c8c119 to
c91e80e
Compare
bf70d77 to
6f6c4b7
Compare
|
Thank you @antten. |
|
changelog entry added in 62fcf93 |
Hello,
It's my first contribution to Symfony and I am really happy to be able to participate in the project.
After analyzing the class \Symfony\Component\Validator\Constraints\IbanValidator, I think the solution proposed in the issue is the right one.