[Security] Display authenticators laziness and exception in the profiler #57382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Jun 15, 2024
There was a problem hiding this comment.
Just a small comment here: what about displaying icons centered? @javiereguiluz
|
I tried displaying authenticators as a list, WDYT?
That way you don’t lose space for missing or redundant data, and you can add some more easily (I have logs in mind e.g.). |
1dfc10a to
7d8c8e1
Compare
|
Closing because it diverged from #57369. Will reopen with a redesign and possibly more data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two pieces of information to each authenticator displayed in the profiler: its laziness (computed from the return of its
supportscall) and an eventualAuthenticationExceptionthrown while executing it.As you can see in the screenshot below (set the profiler’s width to the window’s for the occasion), there may be a better way to display the exception.