[HtmlSanitizer] Add support for configuring the default action #57399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe8b477 to
cf29db7
Compare
Kocal
reviewed
Jun 14, 2024
nicolas-grekas
approved these changes
Jun 24, 2024
Remaining steps would be to make this configuration available through the semantic configuration ? I'd be happy to try it out. |
cf29db7 to
a36fc54
Compare
|
Alright I applied fixes for all feedback received. @Neirda24 yes it would be making sure one can specify a default action in the sanitizer config in FrameworkBundle. Great if you can do that thanks! |
…ck or allow unconfigured elements instead of dropping them
a36fc54 to
4fd1c4c
Compare
fabpot
approved these changes
Jun 29, 2024
|
Thank you @Seldaek. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default action can be set to block or allow unconfigured elements instead of dropping them
Kinda replaces #49920 but it would need some work on the configuration handling side to allow configuring default actions. I am just using this as a library so I am not so keen on doing that part sorry but maybe @Neirda24 might want to take care of it if this PR gets accepted.