[TwigBundle] Moved the registration of the app global to the environment #5741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the app global variable available also when accessing the Twig environment directly instead of using the TwigEngine.
| @@ -75,8 +75,6 @@ public function panelAction(Request $request, $token) | |||
| 'request' => $request, | |||
| 'templates' => $this->getTemplateManager()->getTemplates($profile), | |||
| 'is_ajax' => $request->isXmlHttpRequest(), | |||
| // for BC compatibility | |||
| 'app' => array('request' => $request), | |||
There was a problem hiding this comment.
This should be kept as app may not be available when not using the full-stack framework.
There was a problem hiding this comment.
Well, do we really need to provide BC outside the full-stack framework ? The profiler was not supported outside the framework previously.
thus, if you really want to provide BC, you should provide it for all methods of the GlobalVariables class, not only for the Request getter.
There was a problem hiding this comment.
and btw, this would break the BC for the full-stack framework as you would be replacing the app variable with a variable providing less stuff.
fabpot
added a commit
that referenced
this pull request
Oct 14, 2012
This PR was merged into the master branch. Commits ------- b31ae34 [WebProfilerBundle] Remove the now unneeded BC var and fixed a typo d07ce03 [TwigBundle] Moved the registration of the app global to the environment Discussion ---------- [TwigBundle] Moved the registration of the app global to the environment This makes the app global variable available also when accessing the Twig environment directly instead of using the TwigEngine.
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
This PR was merged into the master branch. Commits ------- b31ae34 [WebProfilerBundle] Remove the now unneeded BC var and fixed a typo d07ce03 [TwigBundle] Moved the registration of the app global to the environment Discussion ---------- [TwigBundle] Moved the registration of the app global to the environment This makes the app global variable available also when accessing the Twig environment directly instead of using the TwigEngine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the app global variable available also when accessing the Twig
environment directly instead of using the TwigEngine.