-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Mailer] [Infobip] Add trackClicks, trackOpens and trackingUrl as supp… #57424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mailer] [Infobip] Add trackClicks, trackOpens and trackingUrl as supp… #57424
Conversation
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
As this is a new feature the PR must target the |
bf5e3ef
to
dc60605
Compare
I updated the target branch and the MR description 👌🏻 |
dc60605
to
c01c981
Compare
I rebased my branch on 7.2 but I don't really understand why I see commit from 7.1 🤔 Do you have an idea ? Executed commands (from the doc):
|
This should be enough: git checkout feat_mailer_infobip_tracking_headers
git fetch upstream
git rebase upstream/7.2 |
I tested but it doesn't fix the issue.. I'll keep searching |
…orted payload properties
c01c981
to
add289e
Compare
I think it was due to the fact I first created my branch from An other question, could it be possible to add this behavior in the next |
No, all new features must be done the next version. Maintained versions only receive bug fixes. |
Thank you @ndousson. |
…(ndousson) This PR was merged into the 7.2 branch. Discussion ---------- [Mailer] [Infobip] Document the usage of custom headers | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT See #57424 Commits ------- fc4403d [Mailer][Infobip] Document the usage of custom headers
…(ndousson) This PR was merged into the 7.2 branch. Discussion ---------- [Mailer] [Infobip] Document the usage of custom headers | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT See symfony/symfony#57424 Commits ------- fc4403df78 [Mailer][Infobip] Document the usage of custom headers
📍 Context
This PR add three headers to configure Infobip email tracking with API V3.
➕ New feature
New payload attribute was added allowing end users to configure tracking.