[Mailer] Add Sweego bridge #57431
Merged
[Mailer] Add Sweego bridge #57431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7de0928 to
9178bba
Compare
OskarStark
reviewed
Jun 17, 2024
src/Symfony/Component/Mailer/Bridge/Sweego/Tests/Transport/SweegoApiTransportTest.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Jun 17, 2024
9178bba to
ab00efd
Compare
OskarStark
approved these changes
Jun 18, 2024
xabbuh
reviewed
Jun 18, 2024
|
@welcoMattic Can we finish this PR without webhook support? |
Sorry for the delay. This PR is still WIP, I'm in touch with Sweego engineers to implement their webhooks. I plan to work on it during august. |
778d938 to
4224669
Compare
4224669 to
bf49afb
Compare
|
The bridge is ready for review! However, I did not implement all webhooks since I need to discuss in detail with Sweego team (plus, they plan to add webhook signature. We will discuss the timing to be able or not to implement it for 7.2). (CI failures seems unrelated) |
fabpot
approved these changes
Aug 19, 2024
|
Thank you @welcoMattic. |
|
@welcoMattic Can you submit a PR on symfony/recipes to add support for this new mailer? |
This was referenced Aug 20, 2024
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Aug 20, 2024
This PR was merged into the 7.2 branch. Discussion ---------- feat(mailer): Add Sweego Mailer doc This PR adds the necessary documentation for Sweego Mailer Bridge and Webhooks. Code PR : symfony/symfony#57431 Commits ------- bad2a21 feat(mailer): Add Sweego Mailer doc
fabpot
added a commit
that referenced
this pull request
Oct 18, 2024
This PR was merged into the 7.2 branch. Discussion ---------- [Notifier] Add Sweego bridge | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | | License | MIT This PR folllows * #57431 This Bridge brings Webhook support for `sent` event for now. Others will follow in the future. `from` parameter is handled on Sweego side (AFAIK, it means one `from` per API Key. `@pydubreucq` can you confirm my words?). Commits ------- ba55f32 Add Sweego Notifier bridge
Merged
fabpot
added a commit
that referenced
this pull request
Nov 18, 2024
… to them! (nicolas-grekas) This PR was merged into the 7.2 branch. Discussion ---------- [Mailer][Notifier] Sweego is backing their bridges, thanks to them! | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT After sponsoring `@welcoMattic` for their bridges (see #58322 and #57431), Sweego doubles down and is now also sponsoring the bridges themselves. Thanks to them! (and give Sweego a try ;) ) /cc `@Wasta`-Geek `@pydubreucq` Commits ------- 600d49e [Mailer][Notifier] Sweego is backing their bridges, thanks to them!
fabpot
added a commit
that referenced
this pull request
Dec 6, 2024
… on Sweego bridges (welcoMattic) This PR was merged into the 7.3 branch. Discussion ---------- [Mailer][Notifier] Add webhooks signature verification on Sweego bridges | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | yes | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT This PR follows the 2 previous ones (#57431, and #58322). It brings webhook signature verification to improve security. Sweego documentation about webhook is here https://learn.sweego.io/docs/webhooks/webhook_signature Commits ------- 9c59199 Add webhooks signature verification on Sweego bridges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new Mailer bridge for 🇫🇷 French based service Sweego.
For now, it does not support attachments, neither webhooks. I'm in touch with @pydubreucq CTO at Sweego to improve this bridge once attachments, webhooks are available.
NB: Docs PR will land later this week