[Mailer] Add additional headers in Scaleway bridge #57499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a new feature and must target 7.2 branch please |
|
Thanks for your quick answer, but isn't this more of a bug fix, since |
|
One could discuss, as the bridge ignores them now, it is some kind of behavior change and we are always very careful with merging such things. |
nicolas-grekas
approved these changes
Jun 24, 2024
|
Without a doubt, this is a new feature (as it introduces a new behavior, even the PR title makes it very clear: "Add..."). |
|
Thank you @MrMicky-FR. |
This was referenced Jun 28, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the missing additional headers in the Scaleway bridge (I forgot to add them in the original implementation). This can be used, for example, to add a
Reply-Toheader that doesn't have its own field, but is supported in theadditional_headersfield (see the Scaleway documentation). Tested with the Scaleway API and is working fine 🚀