[SecurityBundle] Remove unused memory users’ name attribute from the XSD
#57520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @MatTheCat. |
|
Shouldn’t we do this change on 7.2 only? This change now risks that someone receives errors on the next patch release if their XML config still makes use of the now removed attribute. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 28, 2024
* 6.4: Revert "bug #57520 [SecurityBundle] Remove unused memory users’ `name` attribute from the XSD (MatTheCat)" [HttpKernel] Enable optional cache-warmers when cache-dir != build-dir [Filesystem] Fix Filesystem::remove() on Windows [DoctrineBridge] Fix compat with DI >= 6.4 [String] Fix *String::snake methods
nicolas-grekas
added a commit
that referenced
this pull request
Jun 28, 2024
* 7.0: Revert "bug #57520 [SecurityBundle] Remove unused memory users’ `name` attribute from the XSD (MatTheCat)" [HttpKernel] Enable optional cache-warmers when cache-dir != build-dir [Filesystem] Fix Filesystem::remove() on Windows [DoctrineBridge] Fix compat with DI >= 6.4 [String] Fix *String::snake methods
|
@xabbuh @nicolas-grekas using |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 28, 2024
…ibute from the XSD (MatTheCat) This PR was merged into the 6.4 branch. Discussion ---------- [SecurityBundle] Remove unused memory users’ `name` attribute from the XSD | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix cdb8354 | License | MIT #57520 has been reverted because > [The] change […] risks that someone receives errors on the next patch release if their XML config still makes use of the now removed attribute. But nobody could use it since v6.0: as #41613 removed the BC layer, the config would crash. Keeping `name` in the XSD for 6.4, 7.0 and 7.1 branches means people using these versions would have their IDE suggesting an attribute which would make their app crash. Commits ------- ed5c26c [SecurityBundle] Remove unused memory users’ `name` attribute from the XSD
This was referenced Jun 28, 2024
Merged
Merged
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The related config has been deprecated in #40403 and removed in #41613.