[DependencyInjection][Yaml] Add support for flags parsing with binary_flags type and tag
#57522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jun 25, 2024
bddbede to
60354a2
Compare
…y_flags` type and tag
60354a2 to
110876a
Compare
|
Binary expressions can also also have brackets or |
|
Indeed, this is the way instead of reinventing a whole bitfield parser. Worth the extra dependency to me. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 22, 2024
…~` bitwise operators (alexandre-daubois) This PR was merged into the 7.2 branch. Discussion ---------- [ExpressionLanguage] Add support for `<<`, `>>`, and `~` bitwise operators | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT In order to fully support [this idea](#57522 (comment)), I suggest adding to ExpressionLanguage the 3 currently missing bitwise operators, namely left shift, right shift and binary not. ```php use Symfony\Component\ExpressionLanguage\ExpressionLanguage; require 'vendor/autoload.php'; $el = new ExpressionLanguage(); $el->evaluate('1 << 4'); // 16 $el->evaluate('32 >> 4'); // 2 $el->evaluate('~5'); // -6 ``` Commits ------- b470422 [ExpressionLanguage] Add support for `<<`, `>>`, and `~` bitwise operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After symfony/symfony-docs#19965. This PR would allow to write such code (removed NS for readability of the example):
Same goes for XML, where a new
binary_flagstype is added.When parsing,
binary_flagsassumes you give only constants as parameters, the goal is not to rewrite a complete bitwise ops parser.