[SecurityBundle] Improve profiler’s authenticators tab #57525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0ecca2 to
002a527
Compare
002a527 to
80b1ae1
Compare
|
The duration and laziness info feel less readable/structured to me. Looks good apart from that |
|
Okay tried to iterate on my previous idea (code not pushed yet):
Does that look better? |
80b1ae1 to
77872ba
Compare
|
Pushed previously mentioned iteration with small modifications. Updated the PR description accordingly. |
77872ba to
771450c
Compare
chalasr
approved these changes
Jul 13, 2024
There was a problem hiding this comment.
Thanks, I like it. Maybe the lazy info could be a flag instead of yes/no as done elsewhere. Pinging @javiereguiluz in case you can help making this even better.
|
Yay 😀 By “flag”, do you mean “icon”? |
|
Makes sense 👍 |
40ab8d0 to
619d8e4
Compare
619d8e4 to
a8075d4
Compare
fabpot
approved these changes
Jul 25, 2024
|
Thank you @MatTheCat. |
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Jan 6, 2025
…oggles (MatTheCat) This PR was merged into the 6.4 branch. Discussion ---------- [WebProfilerBundle] Fix event delegation on links inside toggles | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | N/A | License | MIT In #57525, the security panel’s authenticator tab got updated with dumps in toggles. Issue is, we currently call `stopPropagation` when link are clicked to avoid closing the toggle, but dumps handle links click using event delegation. That means when you click on a `sf-dump-toggle`, the event cannot reach the `sf-dump` because its propagation is stopped. This PR handles this case by checking if a link is present in the DOM between the toggle and the element which was clicked. It also leverages the `currentTarget` property to get the clicked toggle. Commits ------- 241597d [WebProfilerBundle] Fix event delegation on links inside toggles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new pieces of data to the profiler’s security panel’s authenticators tab: their “laziness” (if their
supportsmethod returnednull) and the exception passed to theironAuthenticationFailuremethod.It also redesigns the table because displaying every possible column leads to a lot of wasted space and decreases legibility:
(You can see the table overflowing its container and the screen.)
Instead, I took inspiration from the messenger panel and
authenticatemethod was calledThis will also make easier to add data if needed.