Skip to content

[HttpClient] Fix initializing InformationalChunk #57564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jun 27, 2024

Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #57563
License MIT

We introduced this regression when we moved DataChunk to CPP: we removed their defaults from properties when doing so.
(Moving to) CPP is dangerous!

Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested code is dangerous :)

@nicolas-grekas nicolas-grekas merged commit 14babeb into symfony:7.1 Jun 28, 2024
7 of 10 checks passed
@nicolas-grekas nicolas-grekas deleted the hc-fix-infochunk branch June 28, 2024 06:08
@fabpot fabpot mentioned this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants