[TwigBridge] Remove random file name for lint:twig output in case of error
#57608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: ERROR in sf_6681e2dd64a2e2.02015003 (line -1) After: ERROR in Standard Input (line -1)
yceruto
approved these changes
Jul 1, 2024
| @@ -89,7 +89,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
| $this->format = $input->getOption('format') ?? (GithubActionReporter::isGithubActionEnvironment() ? 'github' : 'txt'); | |||
|
|
|||
| if (['-'] === $filenames) { | |||
| return $this->display($input, $output, $io, [$this->validate(file_get_contents('php://stdin'), uniqid('sf_', true))]); | |||
| return $this->display($input, $output, $io, [$this->validate(file_get_contents('php://stdin'), 'Standard Input')]); | |||
There was a problem hiding this comment.
other alternatives would be php://stdin or just stdin instead, as we are already familiar with these stream abbreviations.
outputs e.g.
ERROR in php://stdin (line -1)
// or
ERROR in stdin (line -1)
There was a problem hiding this comment.
It's also aimed at front-end developers who only know Twig and not PHP. It could be more specific:
ERROR in Input Template (line -1)
There was a problem hiding this comment.
In any case, I don't think it matters, there's only one linted template, so no doubt about it.
nicolas-grekas
approved these changes
Jul 1, 2024
derrabus
approved these changes
Jul 1, 2024
|
Thank you @GromNaN. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
lint:twig,uniqidis used to generate a file name when linting a template from STDIN.Before:
After:
Note: the
line -1is due to the lack of context provided toTwig\Extra\TwigExtraBundle\MissingExtensionSuggestor::suggestFilter()For reference, this was introduced by #10843