[TwigBridge] Use constant var name to cache trans_default_domain expression result
#57609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trans_default_domain expression resulttrans_default_domain expression result
nicolas-grekas
approved these changes
Jul 1, 2024
fabpot
approved these changes
Jul 1, 2024
|
Thank you @GromNaN. |
|
Using a fixed variable name is actually broken. The Twig scope is shared with all the inheritance tree of templates, so we do have multiple names per scope (as |
Kocal
pushed a commit
to Kocal/symfony
that referenced
this pull request
Feb 13, 2025
… default domain node visitor (xabbuh) This PR was merged into the 7.2 branch. Discussion ---------- [TwigBridge] use reproducible variable names in the default domain node visitor | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | Fix symfony#57609 (comment) | License | MIT Commits ------- 500d72f use reproducible variable names in the default domain node visitor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
trans_default_domainis used with an expression, the result of the expression is cached into a variable and this variable is stored in theScopeto be used for each following usage of the|transfilter.This var name doesn't need to be random:
trans_default_domainis called a second time, the same variable can be reassigned.The only benefit of using a random var name would be to prevent usage in the template. The name
__internal_trans_default_domainself-explains that it is not meant to be used.