Skip to content

[String]  fix handling of punctuation characters in snake() #57615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[String]  fix handling of punctuation characters in snake() #57615

wants to merge 1 commit into from

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 1, 2024

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #57612
License MIT

@carsonbot carsonbot added this to the 5.4 milestone Jul 1, 2024
@carsonbot carsonbot changed the title [String] fix handling of punctuation characters in snake() [String]  fix handling of punctuation characters in snake() Jul 1, 2024
@xabbuh xabbuh mentioned this pull request Jul 1, 2024
Closed
@xabbuh
Copy link
Member Author

xabbuh commented Jul 1, 2024 •
edited
Loading

I borrowed code from the camel() methods of the AbstractUnicodeString and ByteString classes respectively as those methods have been called before #57497.

@xabbuh xabbuh mentioned this pull request Jul 1, 2024
Merged
@derrabus derrabus mentioned this pull request Jul 1, 2024
Merged
@nicolas-grekas
Copy link
Member

Let me close in favor of #57616.
Thanks for the help on the topic!

@xabbuh xabbuh deleted the issue-57612 branch July 1, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review String
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @nicolas-grekas @carsonbot