Skip to content

[PropertyInfo] Add PropertyDescriptionExtractorInterface to PhpStanExtractor #57632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Jul 3, 2024

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues
License MIT

As mentioned in #40457, the PhpStanExtractor should at some point implement the PropertyDescriptionExtractorInterface.

This PR adds that implementation.

@mtarld mtarld requested a review from dunglas as a code owner July 3, 2024 11:42
@carsonbot carsonbot added this to the 7.2 milestone Jul 3, 2024
@chalasr chalasr added ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" and removed ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" labels Oct 4, 2024
@fabpot fabpot modified the milestones: 7.2, 7.3 Nov 20, 2024
@mtarld mtarld force-pushed the feat/implement-property-description-extractor branch from 8348a29 to 833c6eb Compare December 10, 2024 11:19
@mtarld mtarld force-pushed the feat/implement-property-description-extractor branch 3 times, most recently from b256783 to ca2e1c9 Compare December 10, 2024 17:13
@xabbuh
Copy link
Member

xabbuh commented Dec 18, 2024

@mtarld Can you rebase?

@mtarld mtarld force-pushed the feat/implement-property-description-extractor branch from ca2e1c9 to bd80f29 Compare December 18, 2024 09:33
@fabpot
Copy link
Member

fabpot commented Jan 5, 2025

Thank you @mtarld.

@fabpot fabpot merged commit f86c095 into symfony:7.3 Jan 5, 2025
10 of 11 checks passed
@mtarld mtarld deleted the feat/implement-property-description-extractor branch January 5, 2025 13:52
@fabpot fabpot mentioned this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants