[FrameworkBundle] Add flag to sort debug:router output
#57651
Conversation
|
@derrabus This command was not initially considered in the tests. Of course, I can try to write them, but I'm not sure I can do it |
Really? |
|
@derrabus Oh, I only looked at Tests\Command :-) Thanks for the tip |
| \ksort($routesArray); | ||
| foreach ($routesArray as $name => $route) { | ||
| $sortedRoutes->add($name, $route); | ||
| $sortedRoutes->addAlias($route->getDefault('_controller'), $name); |
There was a problem hiding this comment.
I don't get why you add an alias to the controller for every routes.
Not all routes have a controller. Example: _logout_main.
Symfony\Component\Routing\RouteCollection::addAlias(): Argument #1 ($name) must be of type string, null given, called in src/Symfony/Bundle/FrameworkBundle/Command/RouterDebugCommand.php on line 192
|
|
||
| if ('method' === $column) { | ||
| foreach ($routesArray as $name => $route) { | ||
| $methods = empty($route->getMethods()) ? 'ANY' : \implode('|', $route->getMethods()); |
There was a problem hiding this comment.
Since the logic for formatting a list of methods is in the descriptors, it would make sense to move the sorting method into Symfony\Bundle\FrameworkBundle\Console\Descriptor\Descriptor. The method describeRouteCollection has an $options array that could be used to pass the desired sort key.
That would make unit testing a lot easier.
| } | ||
| } | ||
|
|
||
| \ksort($helperArray); |
There was a problem hiding this comment.
Instead of creating an array and using ksort, you can use usort with a callback that compare the sort key of routes 2-by-2. It think there would be less array variables involved.
| @@ -55,6 +55,7 @@ protected function configure(): void | |||
| new InputOption('show-aliases', null, InputOption::VALUE_NONE, 'Show aliases in overview'), | |||
| new InputOption('format', null, InputOption::VALUE_REQUIRED, \sprintf('The output format ("%s")', implode('", "', $this->getAvailableFormatOptions())), 'txt'), | |||
| new InputOption('raw', null, InputOption::VALUE_NONE, 'To output raw route(s)'), | |||
| new InputOption('sort', null, InputOption::VALUE_REQUIRED, 'Sort by column name'), | |||
There was a problem hiding this comment.
Please add the list of possible values as last parameter, for bash completion.
| new InputOption('sort', null, InputOption::VALUE_REQUIRED, 'Sort by column name'), | |
| new InputOption('sort', null, InputOption::VALUE_REQUIRED, 'Sort by column name', null, ['name', 'method', 'scheme', 'host', 'path']), |
debug:router output
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@HMRDevil Are you still interested in finishing this PR? Ask for help if needed. |
|
@fabpot Yes, I will continue what I started as soon as I have a little more free time. |
fcd9528 to
6753b6f
Compare
6753b6f to
0069780
Compare
|
Closing as there is no more activity and some unadressed comments. |
See #54847