[Config][Lock][SecurityBundle] do not use uniqid() in tests #57665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jul 6, 2024
| Q | A |
|---|---|
| Branch? | 7.2 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | part of #57588 |
| License | MIT |
derrabus
approved these changes
Jul 6, 2024
src/Symfony/Component/Config/Tests/Resource/ReflectionClassResourceTest.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Jul 6, 2024
|
Thank you @xabbuh. |
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Jul 6, 2024
updates the remaining tests that were not covered by symfony#57665
fabpot
added a commit
that referenced
this pull request
Jul 6, 2024
… uniqid() in tests (xabbuh) This PR was merged into the 7.2 branch. Discussion ---------- [Filesystem][Messenger][PsrHttpMessageBridge] do not use uniqid() in tests | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | part of #57588 | License | MIT updates the remaining tests that were not covered by #57665 Commits ------- ee7ffbd do not use uniqid() in tests
Merged
fabpot
added a commit
that referenced
this pull request
Jul 8, 2024
This PR was merged into the 7.2 branch. Discussion ---------- [Lock] fix tests | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT I didn't spot early enough that I broke the integration tests in #57665. Commits ------- 785c366 fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.