Skip to content

[Validator] Add setGroupProvider to AttributeLoader #57678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2024
Merged

[Validator] Add setGroupProvider to AttributeLoader #57678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Symfony/Component/Validator/Mapping/Loader/AttributeLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ public function loadClassMetadata(ClassMetadata $metadata): bool
if ($constraint instanceof GroupSequence) {
$metadata->setGroupSequence($constraint->groups);
} elseif ($constraint instanceof GroupSequenceProvider) {
$metadata->setGroupProvider($constraint->provider);
$metadata->setGroupSequenceProvider(true);
} elseif ($constraint instanceof Constraint) {
$metadata->addConstraint($constraint);
Expand Down
21 changes: 21 additions & 0 deletions src/Symfony/Component/Validator/Tests/Mapping/Loader/AttributeLoaderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,22 @@ public function testLoadGroupSequenceProviderAttribute()
$this->assertEquals($expected, $metadata);
}

public function testLoadExternalGroupSequenceProvider()
{
$loader = $this->createAttributeLoader();
$namespace = $this->getFixtureAttributeNamespace();

$metadata = new ClassMetadata($namespace.'\GroupProviderDto');
$loader->loadClassMetadata($metadata);

$expected = new ClassMetadata($namespace.'\GroupProviderDto');
$expected->setGroupProvider('Symfony\Component\Validator\Tests\Dummy\DummyGroupProvider');
$expected->setGroupSequenceProvider(true);
$expected->getReflectionClass();

$this->assertEquals($expected, $metadata);
}

protected function createAttributeLoader(): AttributeLoader
{
return new AttributeLoader();
Expand All @@ -219,4 +235,9 @@ protected function getFixtureNamespace(): string
{
return 'Symfony\Component\Validator\Tests\Fixtures\NestedAttribute';
}

protected function getFixtureAttributeNamespace(): string
{
return 'Symfony\Component\Validator\Tests\Fixtures\Attribute';
}
}