Skip to content

[PropertyInfo]  add tests for TypeInfo types #57696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 9, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

This change ensures that the tests that have been added in #57617 are also applied when the types from the TypeInfo component are used instead of the Type class that is built into the PropertyInfo component.

This change ensures that the tests that have been added in symfony#57617 are
also applied when the types from the TypeInfo component are used instead
of the Type class that is built into the PropertyInfo component.
@xabbuh xabbuh requested a review from dunglas as a code owner July 9, 2024 20:24
@carsonbot carsonbot added this to the 7.1 milestone Jul 9, 2024
@carsonbot carsonbot changed the title [PropertyInfo] add tests for TypeInfo types [PropertyInfo]  add tests for TypeInfo types Jul 9, 2024
@xabbuh
Copy link
Member Author

xabbuh commented Jul 9, 2024

@mtarld FYI

Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@mtarld
Copy link
Contributor

mtarld commented Jul 9, 2024

Nice catch! Thanks @xabbuh 🙂

@fabpot
Copy link
Member

fabpot commented Jul 10, 2024

Thank you @xabbuh.

@fabpot fabpot merged commit 89bd1b4 into symfony:7.1 Jul 10, 2024
7 of 10 checks passed
@xabbuh xabbuh deleted the pr-57617 branch July 10, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants