use more entropy with uniqid() #57697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Jul 10, 2024
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 15, 2024
This PR was merged into the 6.4 branch. Discussion ---------- use more entropy with `uniqid()` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT following #57697 on the `6.4` branch Commits ------- b91e8a2 use more entropy with uniqid()
|
@xabbuh just an observation; looking back at the linked PRs, the original motivation appears to be an optimization as PHP used to skip the Ref: https://github.com/php/php-src/blob/master/ext/standard/uniqid.c |
|
@natewiebe13 Thank you for the hint. I wasn't aware of it, but this was indeed improved in php/php-src@d25049c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looked like using
uniqid()without opting for more entropy slipped in after #20132 and #20137.