[Validator] Add the WordCount constraint
#57716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc846f2 to
3ddca9c
Compare
derrabus
requested changes
Jul 12, 2024
src/Symfony/Component/Validator/Constraints/WordCountValidator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Tests/Constraints/WordCountTest.php
Outdated
Show resolved
Hide resolved
3ddca9c to
c1790e4
Compare
OskarStark
reviewed
Jul 13, 2024
src/Symfony/Component/Validator/Tests/Constraints/WordCountValidatorTest.php
Show resolved
Hide resolved
OskarStark
reviewed
Jul 13, 2024
| yield ['', 1]; // empty string should always pass and eventually be handled by NotBlankValidator | ||
| } | ||
|
|
||
| public static function provideInvalidTypes() |
There was a problem hiding this comment.
Suggested change
| public static function provideInvalidTypes() | |
| public static function provideInvalidTypes(): iterable |
c1790e4 to
37f8770
Compare
|
Pushed plural form of the constraint message |
src/Symfony/Component/Validator/Constraints/WordCountValidator.php
Outdated
Show resolved
Hide resolved
37f8770 to
eccd3be
Compare
xabbuh
reviewed
Jul 17, 2024
xabbuh
reviewed
Jul 17, 2024
eccd3be to
4510f94
Compare
xabbuh
reviewed
Jul 17, 2024
4510f94 to
21544c0
Compare
xabbuh
approved these changes
Jul 17, 2024
OskarStark
approved these changes
Jul 17, 2024
derrabus
approved these changes
Jul 17, 2024
xabbuh
requested changes
Jul 17, 2024
21544c0 to
3786495
Compare
|
Thought of adding a check in the constraint but forgot the tests. Thanks for pointing out, I added |
|
Can you please create and reference a docs PR? Thanks |
xabbuh
approved these changes
Jul 17, 2024
|
@OskarStark of course, here you go: symfony/symfony-docs#20047 |
|
Thank you @alexandre-daubois. |
fabpot
added a commit
that referenced
this pull request
Jul 17, 2024
…raint (OskarStark) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [Validator] Add German translation for `WordCount` constraint | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Needs * #57716 Commits ------- b0eaf91 [Validator] Add German translation for `WordCount` constraint
fabpot
added a commit
that referenced
this pull request
Jul 17, 2024
…n (alexandre-daubois) This PR was merged into the 5.4 branch. Discussion ---------- [Validator] Add `WordCount` constraint French translation | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT :information_source: Requires #57716 to be merged first Commits ------- bd98f5d [Validator] Add `WordCount` constraint French translation
nicolas-grekas
added a commit
that referenced
this pull request
Jul 18, 2024
This PR was merged into the 7.2 branch. Discussion ---------- [Validator] Unwrap useless cast | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT After `@AlexisRossat`'s [comment](#57716 (comment)), the same cast was found at some other places in Validator. Commits ------- 15dc8bd [Validator] Unwrap useless cast
symfony-splitter
pushed a commit
to symfony/validator
that referenced
this pull request
Jul 18, 2024
This PR was merged into the 7.2 branch. Discussion ---------- [Validator] Unwrap useless cast | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT After `@AlexisRossat`'s [comment](symfony/symfony#57716 (comment)), the same cast was found at some other places in Validator. Commits ------- 15dc8bd780 [Validator] Unwrap useless cast
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jul 19, 2024
…ubois) This PR was merged into the 7.2 branch. Discussion ---------- [Validator] Add the `WordCount` constraint Related to symfony/symfony#57716 Commits ------- e983455 [Validator] Add the `WordCount` constraint
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc PR: symfony/symfony-docs#20047