[String] Fix the snake method behavior with uppercase strings and special characters
#57788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better management of uppercase string and removal of special end-of-line characters.
Better management of uppercase string and removal of special end-of-line characters.
c10a2ed to
88bcc3a
Compare
|
We've already tried to fix those methods and that ended up creating regressions. |
|
Closing as explained, thanks for submitting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the
snakemethod is based on thecamelmethod, which does not work correctly with uppercase strings. Thecamelmethod doesn't handle parts of the string in uppercase, which I believe is the correct behavior.For example:
The first example seems correct to me, but this behavior may cause unexpected results in the second example.
To fix the issue, I chose not to base the
snakemethod on thecamelmethod.My proposal may also fix issues #57612 and #57464, and I hope it does not break anything.