[ErrorHandler][VarDumper] Remove PHP 8.4 deprecations #57799
Conversation
9349347 to
99c939a
Compare
| @@ -138,16 +138,16 @@ public static function castDocument(\DOMDocument $dom, array $a, Stub $stub, boo | |||
| 'doctype' => $dom->doctype, | |||
| 'implementation' => $dom->implementation, | |||
| 'documentElement' => new CutStub($dom->documentElement), | |||
| 'actualEncoding' => $dom->actualEncoding, | |||
| 'actualEncoding' => $dom->encoding, | |||
There was a problem hiding this comment.
what about removing the legacy properties instead? casters don't need to report useless data
There was a problem hiding this comment.
I was not sure about how this could be a breaking change thus this update, but I missed the @internal annotation on the class. Definitely better
99c939a to
0e94a95
Compare
0e94a95 to
a310cf6
Compare
a310cf6 to
74b0163
Compare
|
Again it cannot be changed in |
| @@ -23,7 +23,7 @@ | |||
| class DOMCaster | |||
| { | |||
| private const ERROR_CODES = [ | |||
| \DOM_PHP_ERR => 'DOM_PHP_ERR', | |||
| 0 => 'DOM_PHP_ERR', | |||
There was a problem hiding this comment.
Do we need to keep this entry? The way I read the RFC it will no longer be needed:
PR php/php-src#11927 got rid of the last use of DOM_PHP_ERR in PHP. It is a non-standard and non-well-defined error code. The last use was for an out-of-memory situation but that's inconsistent as we normally use INVALID_STATE_ERR for that.
There was a problem hiding this comment.
To me, yes. It's targeting 5.4, and we better be careful and just remove deprecation with the minimum possible updates, and without changing any behavior if possible.
There was a problem hiding this comment.
Well, what I have in mind is adding this entry only in case the used PHP version is before 8.4 (or maybe when the constant is actually defined). Inlining the constant value makes it harder to identify them later when we want to clean up things.
There was a problem hiding this comment.
Even with the plain string next to it? It is stored in a constant array and this will require a bit of extra logic everywhere the array constant is called. Still worth it to you?
| 'encoding' => $dom->encoding, | ||
| 'xmlEncoding' => $dom->xmlEncoding, | ||
| 'standalone' => $dom->standalone, |
There was a problem hiding this comment.
Where is this change coming from?
There was a problem hiding this comment.
| @@ -41,7 +41,7 @@ class ExceptionCaster | |||
| \E_USER_ERROR => 'E_USER_ERROR', | |||
| \E_USER_WARNING => 'E_USER_WARNING', | |||
| \E_USER_NOTICE => 'E_USER_NOTICE', | |||
| \E_STRICT => 'E_STRICT', | |||
| 2048 => 'E_STRICT', | |||
There was a problem hiding this comment.
should be dependent on the presence of the constant IMO (that way we can more easily identify parts of the code to be cleaned up once support for older PHP versions is going to be dropped)
There was a problem hiding this comment.
I think there are few chances to forget it with the plain string next to it. Also, it is stored in a static property in a static class. It also requires extra logic wherever the static property is called, raising chances of introducing a bug if a new usage occurrence of the static property is introduced 😕
|
Thank you @alexandre-daubois. |
…aubois) This PR was merged into the 7.1 branch. Discussion ---------- [ErrorHandler] Fix `E_STRICT` logging level | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Following #57799. In more recent branches, E_* errors logging level were raised from warnings to errors. Commits ------- 390ed6d [ErrorHandler] Fix `E_STRICT` logging level
A new batch of deprecations is coming with PHP 8.4. There's a few things in the code to remove to be completely deprecation free in 5.4. Even if the vote is not finished yet, most deprecations are likely to pass barring a major turn of events.