[FrameworkBundle] Deprecate session.sid_length and session.sid_bits_per_character config options
#57805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07ac3bc to
4253560
Compare
|
For the record, the deprecation poll is closed and it has been confirmed for 8.4: https://wiki.php.net/rfc/deprecations_php_8_4#sessionsid_length_and_sessionsid_bits_per_character |
|
NativeSessionStorage also has references to these ini options. Can you please have a look and advise what we should do there? |
|
NativeSessionStorage should also trigger a deprecation when those options are passed (not just FrameworkBundle) |
676e275 to
99b5c59
Compare
src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php
Outdated
Show resolved
Hide resolved
|
PR updated so NativeSessionStorage also throws a deprecation warning |
src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php
Outdated
Show resolved
Hide resolved
99b5c59 to
6138355
Compare
session.sid_length and session.sid_bits_per_character config optionssession.sid_length and session.sid_bits_per_character config options
rosier
suggested changes
Aug 25, 2024
src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php
Outdated
Show resolved
Hide resolved
72c6f7e to
e31686d
Compare
rosier
approved these changes
Aug 29, 2024
session.sid_length and session.sid_bits_per_character config optionssession.sid_length and session.sid_bits_per_character config options
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
07f3dfe to
34f8f5e
Compare
34f8f5e to
46af076
Compare
46af076 to
1bd4585
Compare
…s_per_character` config options
1bd4585 to
0d2c231
Compare
|
Rebased after the merge of #58244 |
|
Thank you @alexandre-daubois. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 17, 2024
…_length` and `session.sid_bits_per_character` config options (alexandre-daubois) This PR was merged into the 7.2 branch. Discussion ---------- [FrameworkBundle][HttpFoundation] Deprecate `session.sid_length` and `session.sid_bits_per_character` config options Related to symfony/symfony#57805 Fixes #20224 Commits ------- f39be76 [FrameworkBundle][HttpFoundation] Deprecate `session.sid_length` and `session.sid_bits_per_character` config options
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options are (very) likely to be deprecated in PHP 8.4. Because of the many reasons of their deprecation, they may be deprecated in Symfony as well starting the next version.