Skip to content

[Validator] treat uninitialized properties referenced by property paths as null #57812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 24, 2024

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #46347
License MIT

@xabbuh xabbuh force-pushed the issue-46347 branch 2 times, most recently from 6445055 to 020b35a Compare July 24, 2024 07:39
@xabbuh xabbuh force-pushed the issue-46347 branch 3 times, most recently from fdc844f to 2a3a91e Compare July 24, 2024 13:46
nicolas-grekas added a commit that referenced this pull request Jul 26, 2024
This PR was merged into the 5.4 branch.

Discussion
----------

[Validator] properly set up constraint options

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

while working on #57812 I noticed that we did not properly set up some of the constraints which means that tests making use of constraint options were never tested correctly

Commits
-------

a3e0dc9 properly set up constraint options
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit c0929d8 into symfony:5.4 Jul 26, 2024
11 of 12 checks passed
@xabbuh xabbuh deleted the issue-46347 branch July 26, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants