Skip to content

[Console][PhpUnitBridge][VarDumper] Fix NO_COLOR empty value handling #57815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Jul 24, 2024

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues #57777 (comment)
License MIT

NO_COLOR must be non-empty in order to be considered enabled (https://no-color.org/):

when present and not an empty string (regardless of its value)

@carsonbot carsonbot added this to the 5.4 milestone Jul 24, 2024
@OskarStark OskarStark changed the title [Console][PhpUnitBridge][VarDumper] Fix "NO_COLOR" empty value handling [Console][PhpUnitBridge][VarDumper] Fix NO_COLOR empty value handling Jul 24, 2024
@alexandre-daubois alexandre-daubois force-pushed the no-color-empty branch 2 times, most recently from d590275 to d852e24 Compare July 26, 2024 12:21
@nicolas-grekas
Copy link
Member

Thank you @alexandre-daubois.

@nicolas-grekas nicolas-grekas merged commit d4c681c into symfony:5.4 Jul 26, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants