[Serializer][Translation] Deprecate passing a non-empty CSV escape char #57827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5483b69 to
43ad2f7
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jul 26, 2024
…P >= 7.4 (alexandre-daubois) This PR was merged into the 5.4 branch. Discussion ---------- [Translation] Fix CSV escape char in `CsvFileLoader` on PHP >= 7.4 | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Related to #57827. This check has already been done in other places like: https://github.com/symfony/symfony/blob/4a176ceb4b67d1f17cdfb88ecc0946e47a807f65/src/Symfony/Component/DependencyInjection/EnvVarProcessor.php#L310 Commits ------- 0507c22 [Translation] Fix CSV escape char in `CsvFileLoader` on PHP >= 7.4
43ad2f7 to
94aaa75
Compare
|
For the record, the deprecation poll is closed and it has been confirmed for 8.4: https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_proprietary_csv_escaping_mechanism |
5dc0f15 to
9515a39
Compare
mtarld
requested changes
Aug 14, 2024
stof
reviewed
Aug 14, 2024
src/Symfony/Component/Serializer/Tests/Encoder/CsvEncoderTest.php
Outdated
Show resolved
Hide resolved
4597956 to
6c2ae7c
Compare
nicolas-grekas
approved these changes
Aug 19, 2024
src/Symfony/Component/Serializer/Tests/Encoder/CsvEncoderTest.php
Outdated
Show resolved
Hide resolved
6c2ae7c to
1f58925
Compare
fabpot
approved these changes
Aug 19, 2024
|
Thank you @alexandre-daubois. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a non-empty string for CSV escape char will be deprecated in 8.4. Let's deprecate where relevant in the codebase?