[Form] Deprecate VersionAwareTest trait #57839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Jul 26, 2024
|
Question: is |
|
It's not intended to be used by other projects. |
3884191 to
bc3ee44
Compare
Perfect. I've removed the trait usage from there then. This will make it a lot easier to remove the trait in 8.0. |
OskarStark
approved these changes
Jul 26, 2024
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 28, 2024
…outTestCase` (alexandre-daubois) This PR was merged into the 6.4 branch. Discussion ---------- [TwigBridge] Remove `VersionAwareTest` from `AbstractLayoutTestCase` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT I propose to backport what was done in #57839 (cc `@derrabus`) because the test suite currently fails on 6.4 high deps: https://github.com/symfony/symfony/actions/runs/11082470673/job/30795519671#step:8:9163 Commits ------- 4219d16 [TwigBridge] Remove `VersionAwareTest` from `AbstractLayoutTestCase`
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this trait, downstream projects can check if they have at least Symfony Form 4.4 installed. That check should really be a no-op these days.
I haven't removed the usages of this trait since downstream code might still rely on its presence. But I could eliminate all calls to the method that the trait provides.