[Lock] Add $prefix parameter to avoid collision with FlockStore
#57857
Conversation
3ed7270 to
ec32409
Compare
$prefix parameter to avoid collision with FlockStore
| 7.2 | ||
| --- | ||
|
|
||
| * Add parameter `$prefix` to `FlockStore::__construct()` |
There was a problem hiding this comment.
| * Add parameter `$prefix` to `FlockStore::__construct()` | |
| * Add `$prefix` parameter to `FlockStore::__construct()` |
| * | ||
| * @throws LockStorageException If the lock directory doesn’t exist or is not writable | ||
| */ | ||
| public function __construct(?string $lockPath = null) | ||
| public function __construct(?string $lockPath = null, ?string $prefix = null) |
There was a problem hiding this comment.
| public function __construct(?string $lockPath = null, ?string $prefix = null) | |
| public function __construct( | |
| ?string $lockPath = null, | |
| private ?string $prefix = null, | |
| ) |
We can use CPP (constructor property promotion here)
|
Didn't the |
It does. But by default, everything is written in the temp directory and if two Symfony projects use the default configuration they will share the lock. The purpose of this PR is to provide a way to insulate by default the lock per Symfony instance (using the |
|
What about this PR ? The idea is to allow multiple Symfony project to use |
|
I would do it diffently: since by default we have a shared lock space, we should still do that, or we might break apps. |
Currently if two Symfony projects are hosted on the same server and used the same key for a lock using the default
FlockStore, the two applications shared the same lock.So I suggest adding a prefix in the
FlockStoreconstructor to isolate the lock to the current project and avoid collision.This prefix could be initialized with the
kernel.secretparameter by default.To avoid BC, I add the
flock-exclusivelock key configuration.I know this could be done by changing the path a the
FlockStore, but this "exclusive lock" could be the default behaviour of Symfony in the next major release.