[Cache] fix compatibility with redis extension 6.0.3+ #57885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92d2ea6 to
9d860d5
Compare
stof
reviewed
Jul 30, 2024
xabbuh
commented
Jul 30, 2024
|
Thank you @xabbuh. |
|
I'm having a hard time merging this change from 7.1 to 7.2. Can you have a look, @xabbuh? |
|
@derrabus done |
fabpot
added a commit
that referenced
this pull request
Sep 6, 2024
…edric-anne) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Cache] Fix compatibility with Redis 6.1.0 pre-releases | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #57884 | License | MIT The solution provided in #57885 will fix the compatibility with the PHPRedis 6.1.0 release, but the issue persists on the pre-releases (for instance the [6.1.0RC1](https://pecl.php.net/package/redis/6.1.0RC1) version). I propose to use the new signatures for any 6.1.0 version, including its pre-releases. ```php version_compare('6.1.0RC1', '6.1.0', '>='); // false version_compare('6.1.0RC1', '6.1.0-dev', '>='); // true ``` Commits ------- 9569a5f [Cache] Fix compatibility with Redis 6.1.0 pre-releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see the differences in the
redis.stub.phpandredis_cluster.stub.phpfiles at phpredis/phpredis@6.0.2...develop