Skip to content

[FrameworkBundle] Deprecate making cache.app adapter taggable #57927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2024
Merged

[FrameworkBundle] Deprecate making cache.app adapter taggable #57927

merged 1 commit into from
Aug 13, 2024

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Aug 6, 2024 •
edited
Loading

Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? yes
Issues Fix #54339
License MIT

Feedback appreciated on the deprecation message

@carsonbot carsonbot added this to the 7.2 milestone Aug 6, 2024
@alexandre-daubois alexandre-daubois force-pushed the cache-app-tagaware branch 4 times, most recently from 507ffc8 to 2259c64 Compare August 6, 2024 08:13
@alexandre-daubois
Copy link
Member Author

Thanks, comments addressed 👍 I'm having a look at related failures

@alexandre-daubois alexandre-daubois force-pushed the cache-app-tagaware branch 2 times, most recently from 8e5df69 to 51013c1 Compare August 6, 2024 08:42
@alexandre-daubois
Copy link
Member Author

CI is green now

@alexandre-daubois alexandre-daubois force-pushed the cache-app-tagaware branch 2 times, most recently from 8fe8287 to c411932 Compare August 8, 2024 10:11
@nicolas-grekas
Copy link
Member

Thank you @alexandre-daubois.

@nicolas-grekas nicolas-grekas merged commit acc8dda into symfony:7.2 Aug 13, 2024
6 of 10 checks passed
@fabpot fabpot mentioned this pull request Oct 27, 2024
Merged
@keulinho keulinho mentioned this pull request Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Deprecation FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.

Forbid making cache.app tag-aware
4 participants
@alexandre-daubois @nicolas-grekas @xabbuh @carsonbot