Skip to content

DX: simplify PHP CS Fixer config towards v3.62 #57941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

keradus
Copy link
Member

@keradus keradus commented Aug 7, 2024

Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? no
Issues no
License MIT

following #57901

@carsonbot carsonbot added this to the 7.2 milestone Aug 7, 2024
@derrabus
Copy link
Member

derrabus commented Aug 7, 2024

We can also clean up the native_function_invocation override, can't we?

@keradus
Copy link
Member Author

keradus commented Aug 7, 2024

indeed @derrabus 🙇🏻
applied to the PR, also don't hesitate to raise such cleanups whenever you are aware of such possibilities

@xabbuh
Copy link
Member

xabbuh commented Aug 8, 2024

@fabpot Does fabbot need to be updated to use the latest PHP CS fixer version or does that happen automatically?

Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 as soon as @fabpot has updated fabbot. 🤖

@derrabus derrabus added the DX DX = Developer eXperience (anything that improves the experience of using Symfony) label Aug 8, 2024
@OskarStark
Copy link
Contributor

I think it does not work automatically

@fabpot
Copy link
Member

fabpot commented Aug 12, 2024

Thank you @keradus.

1 similar comment
@fabpot
Copy link
Member

fabpot commented Aug 12, 2024

Thank you @keradus.

@fabpot fabpot merged commit 2115c12 into symfony:7.2 Aug 12, 2024
2 of 9 checks passed
@keradus keradus deleted the 7.2_3.62 branch August 12, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX DX = Developer eXperience (anything that improves the experience of using Symfony) Status: Reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants