[DoctrineBridge] Fix the LockStoreSchemaListener
#57944
Conversation
|
Hey! Thanks for your PR. You are targeting branch "7.2" but it seems your PR description refers to branch "6.4". Cheers! Carsonbot |
| @@ -40,20 +39,4 @@ public function testPostGenerateSchemaLockPdo() | |||
| $subscriber = new LockStoreSchemaListener([$lockStore]); | |||
| $subscriber->postGenerateSchema($event); | |||
| } | |||
|
|
|||
| public function testPostGenerateSchemaWithInvalidLockStore() | |||
There was a problem hiding this comment.
Maybe I'm a bit late to the party and missed an important part of the discussion of the previous PR. But… could you recap why we delete a test for a bugfix? I would've expected a new test instead that covers the bug that we want to fix.
There was a problem hiding this comment.
@MatTheCat wrote done his reasoning here: #54407 (comment)
There was a problem hiding this comment.
(I updated the testPostGenerateSchemaLockPdo so that it would fail.)
There was a problem hiding this comment.
You can see testPostGenerateSchemaWithInvalidLockStore is wrong because the function creating the generator is static, but its body is using $this. That means it only passes because the generator is not started and the LockStoreSchemaListener does not get any store.
f356e02 to
5b05c10
Compare
5b05c10 to
db070a1
Compare
|
Thank you @MatTheCat. |
#54407 got sidetracked
and @barton-webwings seems no longer active on GitHubso this PR takes over.