[Scheduler] Add capability to skip missed periodic tasks, only the last schedule will be called #58001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Aug 13, 2024
|
I agree at 99% but don't you thinkk skipMissedRuns make people think that there is not more than one? What do you think to groupMissedRuns(bool) / shouldGroupMissedRuns(): bool |
|
processLastMissedRun / shouldProcessLastMissedRun ? |
fabpot
approved these changes
Aug 19, 2024
…st schedule will be called
70076a9 to
9ae569b
Compare
|
Thank you @eltharin. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Aug 26, 2024
…, only the last schedule will be called (eltharin) This PR was squashed before being merged into the 7.2 branch. Discussion ---------- [Scheduler] Add capability to skip missed periodic tasks, only the last schedule will be called Add documentation for my PR symfony/symfony#58001, Commits ------- 41f1786 [Scheduler] Add capability to skip missed periodic tasks, only the last schedule will be called
Merged
|
without this PR our app got nuked, twice :( BUMP your app ASAP this should've been a hotfix |
|
i should add; without this PR you are severely prone in case of redis failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a Schedule to run only once reccuring messages when a worker break (with stateful enalbed)