-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Security] Deprecate empty user identifier #58007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ajgarlag
commented
Aug 14, 2024
Q | A |
---|---|
Branch? | 7.2 |
Bug fix? | no |
New feature? | no |
Deprecations? | yes |
Issues | Fix #57982 |
License | MIT |
This comment was marked as resolved.
This comment was marked as resolved.
4fd33c8
to
06ed6e6
Compare
src/Symfony/Component/Security/Http/Authenticator/Passport/Badge/UserBadge.php
Outdated
Show resolved
Hide resolved
38e3e37
to
f468116
Compare
Can you also update the Security/Http's CHANGELOG file? The same wording as in the UPGRADE file should work |
Should the phpdoc addition to |
f468116
to
6dabe28
Compare
Please yes in Security\Core |
6dabe28
to
a3ec916
Compare
src/Symfony/Component/Security/Http/Authenticator/Passport/Badge/UserBadge.php
Outdated
Show resolved
Hide resolved
959dbbf
to
7987bc6
Compare
src/Symfony/Component/Security/Http/Tests/Authenticator/Passport/Badge/UserBadgeTest.php
Outdated
Show resolved
Hide resolved
7987bc6
to
e24f8c8
Compare
src/Symfony/Component/Security/Http/Tests/Authenticator/Passport/Badge/UserBadgeTest.php
Outdated
Show resolved
Hide resolved
e24f8c8
to
63690ec
Compare
Thank you @ajgarlag. |
Thank you all for your comments and support! |
Hi, I wonder if this PR is only half-done @nicolas-grekas @chalasr @ajgarlag. What's expected for
And it seems like there is some other method with a |
@VincentLanglet This is enforced at the authenticator level so I think the current behavior is fine functionally speaking. Making user providers throw a specific exception when passed an empty string would be another feature to me. |