[HttpKernel] Improve and add tests for Last-Modified computation with ESI responses
#58011
Conversation
Last-Modified computation with ESI responses
|
|
||
| // Embedded response uses "expiry" model |
There was a problem hiding this comment.
I think "expiry" refers to the maxAge, but we're only using Last-Modified in both reqests. Last-Modified is, to my understanding, one possibly way of revalidation.
There was a problem hiding this comment.
Tests look good to me. I can't honestly tell why I added the Etag to the main response, since (as you said) this should not be relevant at all.
Background: I'm currently investigating a bug where ESI responses miss content. It might be that the change from #42355 – which I think is correct in itself 👍 – creates the condition where the bug appears.
Sounds like HttpCache returns a 304 response without content (which is according to specs), while trying to merge ESI fragments into the main response 🤔
Last-Modified computation with ESI responsesLast-Modified computation with ESI responses
See #58015. |
Last-Modified computation with ESI responsesLast-Modified computation with ESI responses
|
Thank you @mpdude. |
This PR slightly improves the test cases for #42355 (which fixed #41666).
It adds two tests for the cases where
Last-Modifiedshould not be added,and updates the existing test to make it more obvious that we only look at
the existence of
Last-Modifiedheaders, whereas theETagis notrelevant.