Skip to content

[Validator] Add $groups and $payload to Compound constructor #58062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

derrabus
Copy link
Member

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues N/A
License MIT

While reviewing #49547 I noticed that the $groups and $payload parameters introduced in #41994 cannot be leveraged in compound constraints. I'd like to change that.

@derrabus
Copy link
Member Author

cc @alexandre-daubois

@derrabus derrabus force-pushed the improvement/compound-groups branch from 29bd32d to bf4207c Compare August 22, 2024 10:23
@alexandre-daubois
Copy link
Member

Nice! I wondered if this should also be added to the new CompoundConstraintTestCase but I don't think that would be useful, right?

@fabpot
Copy link
Member

fabpot commented Aug 22, 2024

Thank you @derrabus.

@fabpot fabpot merged commit 310fc6a into symfony:7.2 Aug 22, 2024
9 of 10 checks passed
@derrabus derrabus deleted the improvement/compound-groups branch August 22, 2024 17:14
@OskarStark OskarStark changed the title [Validator] Add $groups and $payload to Compound constructor [Validator] Add $groups and $payload to Compound constructor Aug 22, 2024
@fabpot fabpot mentioned this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants