[Uid] Rework internal format conversion #58089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3879b79 to
43910f7
Compare
43910f7 to
736c5a6
Compare
|
Thank you @alexandre-daubois. |
OskarStark
reviewed
Aug 27, 2024
| @@ -214,6 +217,11 @@ private static function transformToRfc4122(string $uuid, int $format): string | |||
| $uuid = $ulid->toRfc4122(); | |||
| } | |||
|
|
|||
| if ($inputUuid === $uuid && !($format & self::FORMAT_RFC_4122)) { | |||
| // input format doesn't match the input string | |||
| return false; | |||
There was a problem hiding this comment.
I didn't want to trigger the heavy exception mechanism (even more for an exception we don't rethrow to the user) for something that we want to be very fast, like validating an UUID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a second look, the control flow is a bit confusing so I propose this refactor to clear things up.