[Lock] Add NullStore
#58109
Merged
[Lock] Add NullStore
#58109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Aug 28, 2024
| Q | A |
|---|---|
| Branch? | 7.2 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Issues | |
| License | MIT |
|
What's the benefit over |
OskarStark
approved these changes
Aug 28, 2024
derrabus
reviewed
Aug 28, 2024
| use Symfony\Component\Lock\BlockingSharedLockStoreInterface; | ||
| use Symfony\Component\Lock\Key; | ||
|
|
||
| class NullStore implements BlockingSharedLockStoreInterface |
There was a problem hiding this comment.
Is the new class covered by a test?
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 23, 2024
This PR was merged into the 7.2 branch. Discussion ---------- [FrameworkBundle] Fix `NullStore` registration | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Follow up to #58109 and #58445, cc `@xabbuh` I'm not sure if there's a way to get the XML config to work with the current schema as `null` is not interpreted as a string: ```xml <framework:resource name="garply">null</framework:resource> ``` Commits ------- cb528eb [FrameworkBundle] Fix `NullStore` registration
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.