Skip to content

[AssetMapper] Search & filter assets in debug:asset-mapper command #58141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2024
Merged

[AssetMapper] Search & filter assets in debug:asset-mapper command #58141

merged 1 commit into from
Sep 27, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Sep 1, 2024 •
edited
Loading

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #...
License MIT
  • Add name optional argument to filter paths & assets
  • Add --ext option to filter assets by extension (e.g "css")
  • Add --vendor option to only show assets from vendor packages (and --no-vendor to hide them)
  • Update command help

Update:
* skip flappy test using chmod on Windows (done by @xabbuh in #58152)

@carsonbot carsonbot added this to the 7.2 milestone Sep 1, 2024
@smnandre smnandre force-pushed the feat/debug-asset-mapper branch from 34ec37f to f6a513f Compare September 1, 2024 22:48
@smnandre smnandre mentioned this pull request Sep 3, 2024
Merged
@smnandre smnandre force-pushed the feat/debug-asset-mapper branch from f578c72 to 0503ec8 Compare September 3, 2024 11:18
@smnandre
Copy link
Member Author

smnandre commented Sep 3, 2024 •
edited
Loading

AssetMapper Tests are green on AppVeyor 🍾

PHPUnit Tests on 8.4 unrelated

Integration tests on 8.2 unrelated

  • (failures on Ldap)

@smnandre
Copy link
Member Author

Ping someone for 7.2 ? 😊

kbond
kbond reviewed Sep 16, 2024
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks useful indeed!

@smnandre smnandre requested a review from kbond September 18, 2024 22:44
@fabpot fabpot force-pushed the feat/debug-asset-mapper branch from 92642af to 8806e24 Compare September 27, 2024 08:35
@fabpot
Copy link
Member

fabpot commented Sep 27, 2024

Thank you @smnandre.

@fabpot fabpot merged commit 1b13c33 into symfony:7.2 Sep 27, 2024
6 of 10 checks passed
@fabpot fabpot mentioned this pull request Sep 27, 2024
Closed
@fabpot fabpot mentioned this pull request Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@kbond kbond kbond approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
AssetMapper Feature Status: Reviewed
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
5 participants
@smnandre @fabpot @kbond @OskarStark @carsonbot