[Ldap] Fix extension deprecation #58143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Sep 2, 2024
OskarStark
approved these changes
Sep 2, 2024
fabpot
approved these changes
Sep 6, 2024
|
Thank you @alexandre-daubois. |
|
Why not just totally removing the call of two argument constructor if the other signature is available since php 5? |
|
Indeed, thank you for pointing this out @Seb33300! |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 11, 2024
…exandre-daubois) This PR was merged into the 5.4 branch. Discussion ---------- [Ldap] Clean `ldap_connect()` call in `LdapTestCase` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT After #58143 (comment), follow-up for #58143 Commits ------- b15cd3d [Ldap] Clean `ldap_connect()` call in `LdapTestCase`
This was referenced Sep 21, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two arguments constructor is deprecated since PHP 8.3: https://www.php.net/manual/en/function.ldap-connect.php